I think you dismiss the solution by cases too quickly.
Actually you only need to do one case, and the rest is developed by symmetry.
The easiest case is when $x+y\geq 0$ and $x - y \geq 0,$
equivalently $x\geq -y$ and $x \geq y,$
or in other words when $(x,y)$ is to the right of both of the lines
$x = y$ and $x= -y.$
In that case the formula simplifies to
$$ (x+y) + (x - y) = 4, $$
that is, $2x = 4,$ so $x = 2.$ We have a vertical line segment from $(2,-2)$ to $(2,2).$
Now observe that the result of $\lvert x+y\rvert +\lvert x-y\rvert$ does not change if we swap $x$ and $y$.
So we also have the mirror image through the line $y=x,$ which says we also have the horizontal line segment from $(-2,2)$ to $(2,2).$
Notice how this is two adjacent sides of the square with vertices
$(-2,2),$ $(2,2),$ $(2,-2),$ and $(-2,-2).$
Also observe that the result of $\lvert x+y\rvert +\lvert x-y\rvert$ does not change if we replace $x$ and $y$ with $-x$ and $-y$.
So we also have symmetry via a reflection through the origin, which is also a $180$-degree rotation around the origin.
That gives us the other two sides of the square.