The definition of "regular" in the differential geometry of curves just means that for each value of the parameter, the parameterization gives a nonzero tangent vector at the corresponding point on the curve. This doesn't mean that the tangent line containing that tangent vector is unique, and the nodal cubic illustrates this: when $t=-1$ we get one tangent vector at $(0,0),$ and when $t=1$ we get another tangent vector which is not parallel to the first one.
With that in mind, we might strengthen the definition of regular to something like "a very regular parametrised curve is one which whose parametrization is injective and whose velocity is never zero". Then we see that the injectivity condition implies that the curve fails to be regular at $(0,0)$, as expected.
Finally, note that your computation actually does tell us that there are no values of $t$ for which the velocity vector is zero. So away from the point where injectivity fails, the curve is regular (which is expected because it is smooth everywhere else).
By the way, when I first read the question, I thought that regularity assumed injectivity anyway (and this is my own personal preference, if that counts for anything); but then I did some googling and it seems that a number of courses don't assume the parametrization is injective!